Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Closes #26973: adjust wallpaper onboarding ui #26974

Merged
merged 3 commits into from
Sep 15, 2022
Merged

Closes #26973: adjust wallpaper onboarding ui #26974

merged 3 commits into from
Sep 15, 2022

Conversation

mavduevskiy
Copy link
Contributor

@mavduevskiy mavduevskiy commented Sep 14, 2022 •
edited by github-actions bot
Loading

Adjusting wallpaper onboarding ui.

device-2022-09-13-193226.webm
device-2022-09-14-113053.webm

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #26973

@mavduevskiy mavduevskiy requested review from a team as code owners September 14, 2022 02:21
@mavduevskiy mavduevskiy reopened this Sep 14, 2022
@gabrielluong gabrielluong added the pr:approved PR that has been approved label Sep 14, 2022
@mavduevskiy mavduevskiy force-pushed the adjust-wallpaper-onboarding-ui branch from 9f78f64 to 473c469 Compare September 14, 2022 19:00
@mavduevskiy mavduevskiy reopened this Sep 14, 2022
@AaronMT
Copy link
Contributor

AaronMT commented Sep 14, 2022

(This will need a rebase from this morning as as Fenix's main branch protection rules changed ui-test-x86 to ui-test-arm)

@mavduevskiy mavduevskiy force-pushed the adjust-wallpaper-onboarding-ui branch from 473c469 to fda4d33 Compare September 14, 2022 20:09
@mavduevskiy
Copy link
Contributor Author

@AaronMT thanks for the tip!

@mavduevskiy mavduevskiy reopened this Sep 14, 2022
@mavduevskiy mavduevskiy force-pushed the adjust-wallpaper-onboarding-ui branch from fda4d33 to a39c715 Compare September 15, 2022 00:13
@mavduevskiy mavduevskiy reopened this Sep 15, 2022
@mavduevskiy mavduevskiy added the pr:needs-landing-squashed PRs that are ready to land (squashed) [Will be merged by Mergify] label Sep 15, 2022
@mergify mergify bot merged commit 7fc96b0 into mozilla-mobile:main Sep 15, 2022
@github-actions github-actions bot mentioned this pull request Oct 20, 2022
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this pull request Feb 14, 2023
@mavduevskiy @rvandermeulen @mergify
[fenix] Closes mozilla-mobile/fenix#26973: adjust wallpaper onboardin…
25acaba 
…g ui (mozilla-mobile/fenix#26974)

Co-authored-by: mike a <mavduevskiy@gmail.com>
Co-authored-by: Ryan VanderMeulen <rvandermeulen@mozilla.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gabrielluong gabrielluong gabrielluong approved these changes

Assignees
No one assigned
Labels
pr:approved PR that has been approved pr:needs-landing-squashed PRs that are ready to land (squashed) [Will be merged by Mergify]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adjust wallpaper onboarding design
4 participants
@mavduevskiy @AaronMT @gabrielluong @rvandermeulen